Limit the size of copy to the minimum of what was asked
for or the number of results returned to prevent leaking of
uninitialized kernel memory to userspace.
Bug: 24157888
Signed-off-by: Patrick Tjin <pattjin@google.com>
Change-Id: I941298dbd222dca1601c66ba96a56bfdda9e8243
The socket associated with an IPC Router port can be released before
the port is released. This leads to an use after free bug in cases
where the socket is closed while a packet is in flight.
Fix the use after free scenario by holding a sock reference during
creation of the port and releasing that in release port function.
CRs-Fixed: 811335
Change-Id: I638cc59e3b4e2347107e5ac19f233b0f7b9dd7b0
Signed-off-by: Atish Kumar Patra <apatra@codeaurora.org>
Add support for blocking sends that enables the sender to wait for
the resume transmit signal from a remote endpoint.
Change-Id: Id7a27ccda4d07b14a81e1a4ec4429785df3c31c6
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
Update the receive operation to be blocking by default and use MSG_DONTWAIT
flag to enable non-blocking receive operation.
Change-Id: I4d460ac3a57cbca4bd9756b42326805927d601ff
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
Enable support for connect system call, so that the destination address is
stored as part of the port. Subsequently the clients of IPC Router can use
send and recv system calls in addition to sendto and recvfrom.
Reset any connection between the local port and remote port if the remote
port exits either voluntarily or due to subsystem restart.
Change-Id: Icf45934a1fc9d01ff96f2a7a47359b66ac22ccbd
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
If clients use custom serialization functions, then they may need to
define a version for deserialization support for log extraction.
Add client version support.
Change-Id: Id135f06d4142de39275b5d0caab88708d5496b5e
Signed-off-by: Eric Holmberg <eholmber@codeaurora.org>
IPC Router logs error messages to kernel log. These error messages
do not have a common string to search for in kernel logs which makes
it difficult to identify the IPC Router error message while debugging
issues.
Add a common string as a part of error message printed from IPC Router.
Change-Id: Ie87e4bdb215fe7d7ef4c5788a77f862e312f80f2
Signed-off-by: Zaheerulla Meer <zmeer@codeaurora.org>
When loading either a non-modem image or when PIL returns an error,
the PIL handle is left uninitialized. This results in a kernel
panic when the handle is used to do a PIL unload.
Initialize the pil handle in this error case to avoid kernel panic.
CRs-Fixed: 636748
Change-Id: I83fb2ff822851e0b5a35cb32b440671b46068d85
Signed-off-by: Steven Cahail <scahail@codeaurora.org>
IPC Router votes for the modem by default to ensure that the modem is
loaded so QMI services can be discovered. However, this causes a large
delay measured in seconds for the first client to bind to an IPC Router
socket. For clients that do not need the modem, this delay is
unnecessary.
Move the PIL loading to a single-threaded workqueue to load the modem
and maintain reference counting asynchronously.
Change-Id: I2a2a375fa4538442e5a16465935a07ba1d7437b8
Signed-off-by: Eric Holmberg <eholmber@codeaurora.org>
Signed-off-by: Steven Cahail <scahail@codeaurora.org>
Add support for compat_ioctl, compat_getsockopt, compat_setsockopt
operations to ensure compatibility for applications that require it.
Change-Id: I792577c0ea96fee27f47acb480bc1129a0eb2803
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
%zu is the correct printk format specifier when printing size_t types.
Update printks to use %zu for size_t type variables.
Change-Id: I550b7853aeb1bdaaadf23ecfa9e1383b7f15ad89
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
Upstream prefers existing drivers be converted to support multiplatform
kernels. This requires drivers to be located in generic functionality
directories instead of specific mach directories.
Move IPC Router Core and Security drivers to the net/ipc_router location
to support multi-platform.
Move IPC Router SMD & HSIC transport(XPRT) drivers to the drivers/soc/qcom
location.
Change-Id: I770227f66dcb776b26086426f509568f991db757
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
Patrick Tjin